Skip to content

feat(storage): check presubmits on HEAD #1770

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
googlyrahman wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

feat(storage): check presubmits on HEAD #1770

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
879cb7c
feat(storage): update comment
googlyrahman Mar 15, 2026
660cf52
Merge branch 'main' into temp
googlyrahman Mar 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion google/cloud/storage/asyncio/retry/reads_resumption_strategy.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ def update_state_from_response(
) -> None:
"""Processes a server response, performs integrity checks, and updates state."""

# Capture read_handle if provided.
# Capture read_handle if provided
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Mar 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For consistency with the PEP 8 style guide, comments that are complete sentences should end with a period. Please add the period back to this comment.

Suggested change
# Capture read_handle if provided
# Capture read_handle if provided.
References
  1. PEP 8, the style guide for Python code, recommends that comments be written as complete sentences. This includes proper punctuation, such as ending a sentence with a period. (link)

if response.read_handle:
state["read_handle"] = response.read_handle

Expand Down
Loading