chore: skip hmac tests until b/493225655 is fixed

[nidhiii-27]

Skipping hmac tests if they fail with a 412 PreconditionFailed. This is occurring because the testing project python-docs-samples-tests has the constraints/iam.disableServiceAccountKeyCreation Organization Policy enforced.

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request aims to improve the stability of the test suite by addressing a known issue where HMAC key creation tests fail due to an organizational policy that disables service account key creation. By introducing a mechanism to detect this specific error and conditionally skip the affected tests, the PR ensures that the test suite can continue to run without being blocked by this external configuration, pending a permanent resolution.

Highlights

• Test Stability: Implemented conditional skipping for HMAC key creation tests to prevent failures caused by a PreconditionFailed error, specifically when the constraints/iam.disableServiceAccountKeyCreation organization policy is enforced.

Changelog

• samples/snippets/hmac_samples_test.py
  • Removed an unnecessary blank line.
  • Wrapped the create_hmac_key call in a try-except block to catch google.api_core.exceptions.PreconditionFailed.
  • Added logic to skip the test using pytest.skip if the PreconditionFailed error is due to the constraints/iam.disableServiceAccountKeyCreation policy.
  • Simplified the call to storage_create_hmac_key.create_key by removing line breaks.

Activity

• No human activity has been recorded for this pull request yet.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request adds logic to skip HMAC tests when they fail due to a specific organization policy. The implementation in the new_hmac_key fixture is mostly correct, and I've suggested a small improvement for re-raising exceptions to preserve the stack trace. Additionally, test_create_key was missed and will still fail; I've provided a suggestion to apply the same skipping logic there to ensure all relevant tests are skipped as intended.