Skip to content

Use equality instead of identity for enum value comparison #1602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Hassad674 wants to merge 1 commit into
base: master
Choose a base branch
from
+15 −1
Open

Use equality instead of identity for enum value comparison #1602

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion graphene/types/enum.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,9 @@
def eq_enum(self, other):
if isinstance(other, self.__class__):
return self is other
return self.value is other
if isinstance(other, PyEnum):
return NotImplemented
return self.value == other


def hash_enum(self):
Expand Down
12 changes: 12 additions & 0 deletions graphene/types/tests/test_enum.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -613,3 +613,15 @@ def resolve_color(_, info):
results = schema.execute("query { color }")
assert not results.errors
assert results.data["color"] == RGB.description.name


def test_enum_value_equality():
class Kind(Enum):
FAVORABLE = "favorable"
UNFAVORABLE = "unfavorable"

# non-interned string to avoid identity matching
val = "".join(["favor", "able"])
assert Kind.FAVORABLE == val
assert Kind.FAVORABLE == "favorable"
assert Kind.FAVORABLE != "unfavorable"