Skip to content

CTORNDGAIN-1329 added LSP integration#60

Open
bbiloskursky1 wants to merge 1 commit intomainfrom
feature/CTORNDGAIN-1329
Open

CTORNDGAIN-1329 added LSP integration#60
bbiloskursky1 wants to merge 1 commit intomainfrom
feature/CTORNDGAIN-1329

Conversation

@bbiloskursky1
Copy link
Copy Markdown
Contributor

No description provided.

@github-actions
Copy link
Copy Markdown
Contributor

Rosetta Triage Review

Summary: Adds a new lsp-install skill that detects the workspace tech stack and installs Language Server Protocol servers for supported languages (TypeScript/JS, Python, Go, Rust, Java, C#, Kotlin), integrated as an optional step in the init-workspace-flow-questions.md workflow and synced across all plugin variants.

Findings:

  • Empty PR body: No description provided. Reviewers lack context on what changed, how it was tested, and any known limitations. Please add a summary referencing CTORNDGAIN-1329.
  • Incomplete Python version check: li-install-scripts.md captures the Python version but never validates it against the ≥3.9 requirement — the comparison is left as a comment (# Check version >= 3.9) with no actual comparison logic.
  • Hardcoded JDTLS version: The Java installation script hardcodes JDTLS_VERSION="1.40.0" which will become stale as Eclipse releases new milestones.
  • Unexpected model in SKILL.md frontmatter: model: claude-haiku-4-5, gemini-3-flash-preview — per ARCHITECTURE.md, Claude Code Plugin only supports Anthropic models. The gemini-3-flash-preview entry may not be honored and could confuse tooling.
  • Silent mode not implemented: IMPLEMENTATION.md notes "silent mode via ROSETTA_ENABLE_LSP=true" but neither the skill nor the workflow implement this env-var-based path.

Suggestions:

  • Add a PR description explaining the feature scope, testing approach, and known limitations.
  • Fix the Python version validation — add an actual comparison after capturing the version string.
  • Consider dynamically fetching the latest JDTLS version or adding a comment that the version must be periodically updated.
  • Remove or clarify the gemini-3-flash-preview model entry in the skill frontmatter.
  • Implement the ROSETTA_ENABLE_LSP=true silent mode or remove the reference from IMPLEMENTATION.md.

Automated triage by Rosetta agent

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants