Skip to content

springboot 3.5.11#786

Merged
AbdelHedhili merged 8 commits intomainfrom
springboot_3.5.11
Apr 1, 2026
Merged

springboot 3.5.11#786
AbdelHedhili merged 8 commits intomainfrom
springboot_3.5.11

Conversation

@AbdelHedhili
Copy link
Copy Markdown
Contributor

Signed-off-by: Abdelsalem abdelsalem.hedhili@rte-france.com

Signed-off-by: Abdelsalem <abdelsalem.hedhili@rte-france.com>
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Mar 23, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: fd98e000-c08c-4e3b-a468-88e71438e789

📥 Commits

Reviewing files that changed from the base of the PR and between 338c8d1 and 9b42c1d.

📒 Files selected for processing (4)
  • pom.xml
  • src/test/java/org/gridsuite/modification/server/modifications/LineCreationInBusBreakerTest.java
  • src/test/java/org/gridsuite/modification/server/modifications/LineCreationInNodeBreakerTest.java
  • src/test/java/org/gridsuite/modification/server/utils/elasticsearch/EmbeddedElasticsearch.java

📝 Walkthrough

Walkthrough

This PR updates the gridsuite-dependencies version to 50.0.0, removes legacy version property overrides for network modification, network store client, and testcontainers, updates test assertions to match changed error message capitalization, and upgrades the Elasticsearch Docker image from 8.15.5 to 8.19.10.

Changes

Cohort / File(s) Summary
Dependency Management
pom.xml
Updated gridsuite-dependencies.version to 50.0.0; removed legacy properties (network-modification.version, network-store-client.version, testcontainers.version) and associated dependency overrides.
Test Assertions
src/test/java/org/gridsuite/modification/server/modifications/LineCreationInBusBreakerTest.java, src/test/java/org/gridsuite/modification/server/modifications/LineCreationInNodeBreakerTest.java
Updated error message assertions to match changed capitalization: "AC Line" → "AC line".
Test Infrastructure
src/test/java/org/gridsuite/modification/server/utils/elasticsearch/EmbeddedElasticsearch.java
Updated Elasticsearch Docker image version from 8.15.5 to 8.19.10.
🚥 Pre-merge checks | ❌ 3

❌ Failed checks (1 warning, 2 inconclusive)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
Title check ❓ Inconclusive The title 'springboot 3.5.11' is vague and does not clearly convey the changeset's primary modifications, which include dependency version updates, legacy property removal, test assertion updates, and Elasticsearch image version changes. Use a more descriptive title that captures the main changes, such as 'Update Spring Boot to 3.5.11 and clean up dependency overrides' or 'Upgrade dependencies and remove legacy version properties'.
Description check ❓ Inconclusive The description contains only a sign-off line and does not provide any meaningful information about the pull request's changes, objectives, or rationale. Add a meaningful description explaining the purpose of the changes, such as dependency upgrades, version removals, and test updates performed in this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@etiennehomer etiennehomer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ES_DOCKER_IMAGE_VERSION to upgrade

@sonarqubecloud
Copy link
Copy Markdown

@AbdelHedhili AbdelHedhili merged commit 90f314b into main Apr 1, 2026
4 checks passed
@AbdelHedhili AbdelHedhili deleted the springboot_3.5.11 branch April 1, 2026 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants