Skip to content

创建新session时记住上次的选项#2

Open
lihaozheCharlie wants to merge 4 commits intohetaoBackend:mainfrom
lihaozheCharlie:main
Open

创建新session时记住上次的选项#2
lihaozheCharlie wants to merge 4 commits intohetaoBackend:mainfrom
lihaozheCharlie:main

Conversation

@lihaozheCharlie
Copy link
Copy Markdown
Collaborator

No description provided.

- Clear and sharp text for the title, do not repeat all the titles in reference images.
- Vibrant colors and "Cover Art" aesthetic.
- Only present one row one panel in the cover.
- 生成的图片务必使用中文
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个地方需要结合当前前端选择的漫画语言,不能写死

@hetaoBackend
Copy link
Copy Markdown
Owner

@codex please review it

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 9809884562

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

return jsonify({"error": "Google API key is required"}), 400

comic_style = data.get('comic_style', 'doraemon')
language = data.get('language', 'en')
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Preserve cover prompt language for existing clients

The new data.get('language', 'en') default changes every existing /api/generate-cover call to English, because the current frontend caller in frontend/js/api.js:183-192 still sends only comic_style, google_api_key, and reference_imgs. Before this patch _create_cover_prompt() always required Chinese text, so any cover generated from the shipped UI (or any older client) will now regress from Chinese to English unless the frontend and backend changes are deployed together.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants