Open
Conversation
sayakpaul
previously approved these changes
Mar 27, 2026
Member
sayakpaul
left a comment
sayakpaul
left a comment
There was a problem hiding this comment.
Nice. Should we also let users configure if they want to supress progress bars entirely?
kernel-builder/Cargo.toml
Outdated
| @@ -16,6 +16,7 @@ clap_complete = "4" | |||
| eyre = "0.6.12" | |||
| git2 = "0.20" | |||
| huggingface-hub = { git = "https://github.com/huggingface/huggingface_hub_rust.git", rev = "8cbc662035e04d4be8e829316272893e980f5926", package = "huggingface-hub", features = ["blocking", "xet"] } | |||
Member
There was a problem hiding this comment.
I guess this needs to be updated once huggingface/huggingface_hub_rust#9 is in?
Collaborator
Author
yep, the new kernels/kernel-builder/src/main.rs Line 113 in ac5d89d |
Collaborator
Author
|
Note: i've pinned the specific branch since the upstream PR may be refactored before merge. I think its low risk to pin and merge since the library has all of the functionality we intend on using, and once refactors are complete I'll open a PR to resolve any changes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a progress bar to uploads for both the lfs and non lfs file uploads
note: this PR is dependent on huggingface/huggingface_hub_rust#9 and needs to bump the commit hash after that PR is merged for this to work
progressexample.mp4