Update nixpkgs and other flake dependencies#425
Merged
Conversation
Before this change we erroneously inherited `callPackage` from nixpkgs. This `callPackage` does not have access to the new scope (the ROCm/XPU package set). However, this error was masked by `makeScope` overriding `callPackage`, so `final` had the correct version. The latest nixpkgs supports overriding `callPackage`, which surfaced this bug.
We use our own hook.
This check takes a long time, sometimes times out, and is already checked upstream.
`dlopen` by the Python interpreter failed with: cannot enable executable stack as shared object requires: Invalid argument Pass the `-z noexecstack` to the linker to mark the library as not requiring an executable stack.
danieldk
commented
Apr 2, 2026
|
|
||
| in | ||
| buildPythonPackage { | ||
| buildPythonPackage.override { stdenv = effectiveStdenv; } { |
Member
Author
There was a problem hiding this comment.
Using stdenv in the attrset passed to buildPythonPackage is now deprecated in nixpkgs.
danieldk
commented
Apr 2, 2026
| } | ||
|
|
||
| if [ -z "${dontCheckRuntimeDeps-}" ]; then | ||
| if [ -z "${dontCheckWheelDeps-}" ]; then |
Member
Author
There was a problem hiding this comment.
Forgot to rename this when adding this hook to our repo, but the name now clashes with the same variable in the original hook in nixpkgs.
danieldk
commented
Apr 2, 2026
Comment on lines
+12
to
+17
| inherit (lib.fixedPoints) extends composeManyExtensions; | ||
|
|
||
| fixedPoint = final: { | ||
| inherit lib packageMetadata; | ||
| }; | ||
| composed = composeManyExtensions [ |
Member
Author
There was a problem hiding this comment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.