chore: Go 1.24, grpc 1.79.3, and flexible Alpine apk pins#1730
Merged
peterbroadhurst merged 1 commit intomainfrom Mar 23, 2026
Merged
chore: Go 1.24, grpc 1.79.3, and flexible Alpine apk pins#1730peterbroadhurst merged 1 commit intomainfrom
peterbroadhurst merged 1 commit intomainfrom
Conversation
- Require Go 1.24 / toolchain in root go.mod; align CI setup-go and firefly-builder image (golang:1.24-alpine). - Raise google.golang.org/grpc to v1.79.3 (CVE-2026-33186) in root and Fabric chaincode modules; go mod tidy. - Dockerfile: use >= for build and runtime apk packages so builds keep working as Alpine indexes move forward. Signed-off-by: Enrique Lacal <enrique.lacal@kaleido.io>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1730 +/- ##
=======================================
Coverage 99.94% 99.94%
=======================================
Files 342 342
Lines 25022 25022
=======================================
+ Hits 25007 25008 +1
- Misses 9 10 +1
+ Partials 6 4 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
peterbroadhurst
approved these changes
Mar 23, 2026
| }, | ||
| "build": { | ||
| "firefly-builder": { | ||
| "image": "golang:1.23-alpine3.21" |
Contributor
There was a problem hiding this comment.
I'm was unsure we could un-pin this to at least an alpine major version, but I see it's really only last digit that changes for alpine looking at golang tags ✅
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
go.mod/ toolchain,manifest.jsonfirefly-builder, and GitHub Actionssetup-gouse Go 1.24 so builds and images match.google.golang.org/grpcto v1.79.3 in the main module (transitive via migrate/viper/etc.) and Fabric sample chaincode modules to address CVE-2026-33186.apkpins (=) with minimum versions (>=) on the firefly-builder and final stages so package updates (e.g. gcc 15, newer curl/git) no longer conflict withbuild-base/ the index.Types of changes
Please make sure to follow these points