Improve navbar accessibility and labels#28
Open
tripledoublev wants to merge 4 commits intofeat/ballot-questionsfrom
Open
Improve navbar accessibility and labels#28tripledoublev wants to merge 4 commits intofeat/ballot-questionsfrom
tripledoublev wants to merge 4 commits intofeat/ballot-questionsfrom
Conversation
Member
Author
fastfadingviolets
approved these changes
Apr 2, 2026
Member
Author
|
While testing this in the browser, we found a keyboard accessibility bug in the desktop navbar dropdowns. The dropdown rows were composed as Fixed in 98105413 |
…ssibility-navbar # Conflicts: # styles/globals.css
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

This improves navbar accessibility and clarity without intentionally changing the overall shell layout.
What changed
components/Navbar.tsx: replaces the mobile site-menu trigger with a real<button>and addsaria-controls,aria-expanded, and an open/close labelcomponents/Navbar.tsx: replaces the mobile profile-menu trigger with a real<button>and adds the same accessibility attributescomponents/Navbar.tsx: marks the mobile close icons as decorative withalt=""andaria-hidden="true"components/Navbar.tsx: increases desktop dropdown trigger contrast from muted text to full whitecomponents/NavbarComponents.tsx: shortens top-level desktop nav labels from “Browse Bills / Browse Hearings / Browse Testimony / Browse Ballot Questions” to “Bills / Hearings / Testimony / Ballot Questions”public/locales/en/common.json: adds the new shorter label strings plus explicit open/close menu labels for assistive techstyles/globals.css: adds a visible keyboard focus style for the mobile nav trigger buttonsWhat to look for in the browser
http://localhost:3003)Tabto focus the left menu trigger and the right profile triggerGood pages to test
/What should stay the same
Deeper verification
<button>elementsaria-controlsandaria-expandedSummary