Fix Object Initializers Referencing Other Properties (#1080)#1233
Merged
GrahamTheCoder merged 1 commit intomasterfrom Mar 14, 2026
Merged
Fix Object Initializers Referencing Other Properties (#1080)#1233GrahamTheCoder merged 1 commit intomasterfrom
GrahamTheCoder merged 1 commit intomasterfrom
Conversation
Co-authored-by: GrahamTheCoder <2490482+GrahamTheCoder@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1080 where VB.NET object initializers referencing other properties (e.g.
New Point() With { .X = 1, .Y = .X }) caused aKeyNotFoundExceptionduring conversion to C# because the code incorrectly assumed anyNamedFieldInitializerbelonged to an anonymous type and tried to look up its temporary initialization variable in_tempNameForAnonymousScope.The fix introduces a safe lookup via
TryGetValue, falling back to_withBlockLhs.Peek()for regular object initializers. Two unit tests reproducing the issue and testing an advanced case are included.PR created automatically by Jules for task 6482098657889880382 started by @GrahamTheCoder