Fix lambda block unpacking with comments#1235
Open
GrahamTheCoder wants to merge 1 commit intomasterfrom
Open
Conversation
When a single statement lambda contained comments, unpacking it to an expression body or an unparenthesized block resulted in the comments being pushed outside the lambda when it's placed inside method invocations like `Parallel.ForEach`. This checks for comments in the lambda node and forces generating a full block syntax to preserve the comments inside. Co-authored-by: GrahamTheCoder <2490482+GrahamTheCoder@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1013 by ensuring that lambda bodies containing comments are converted using a full BlockSyntax rather than being unpacked to an expression body or unparenthesized statement, which previously caused comments to jump outside the lambda loop in resulting C# code. Added a test matching the issue's repro without compilation errors by substituting DataTable with a simpler generic List.
PR created automatically by Jules for task 17420352820605040508 started by @GrahamTheCoder