Fix XML literals to be XML-decoded when converted to C# strings#1236
Open
GrahamTheCoder wants to merge 1 commit intomasterfrom
Open
Fix XML literals to be XML-decoded when converted to C# strings#1236GrahamTheCoder wants to merge 1 commit intomasterfrom
GrahamTheCoder wants to merge 1 commit intomasterfrom
Conversation
This updates `XmlExpressionConverter.cs` to use `ValueText` instead of `Text` when converting XML strings and text nodes so that XML entities like `<` are correctly evaluated as their decoded values. The test expectations have been updated appropriately to match the resulting actual string outputs which naturally produce the raw decoded literal character escapes like `\n` instead of verbatim multiline formats. A unit test proving the fix for the reported issue is also included. Co-authored-by: GrahamTheCoder <2490482+GrahamTheCoder@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #961 by converting XML strings with properly decoded entities.
PR created automatically by Jules for task 573062425952386226 started by @GrahamTheCoder