Skip to content

Extend power analysis to all estimators + simulation-based MDE/sample size #208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
igerber wants to merge 11 commits into
base: main
Choose a base branch
from
Open

Extend power analysis to all estimators + simulation-based MDE/sample size #208

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
33364d9
Extend power analysis to all estimators and add simulation-based MDE/…
igerber Mar 18, 2026
c412e4a
Address PR #208 review: remove ContinuousDiD from registry, validate …
igerber Mar 18, 2026
2a2fd95
Address PR #208 review: remove TWFE from registry, add lo-sufficient …
igerber Mar 18, 2026
9b29d7e
Address PR #208 review: cap SyntheticDiD treatment_fraction to fix ze…
igerber Mar 18, 2026
35df624
Address PR #208 review: replace silent SyntheticDiD treatment_fractio…
igerber Mar 18, 2026
bbbacc0
Address PR #208 review: add TWFE to registry, fix unregistered-estima…
igerber Mar 18, 2026
d1f2316
Add result_extractor param, fix stale power.rst docs, and add missing…
igerber Mar 18, 2026
800d37f
Warn when staggered estimator settings don't match default power DGP
igerber Mar 18, 2026
9e18a3e
Fix SDID placebo check to account for data_generator_kwargs n_treated…
igerber Mar 18, 2026
0e912bb
Warn when TripleDifference power params don't match fixed 2×2×2 DGP
igerber Mar 18, 2026
fa93bea
Fix DDD n_per_cell suppression scope and add sample-size auto-bracket…
igerber Mar 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions TODO.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,7 @@ Deferred items from PR reviews that were not addressed before merge.
| Bootstrap NaN-gating gap: manual SE/CI/p-value without non-finite filtering or SE<=0 guard | `imputation_bootstrap.py`, `two_stage_bootstrap.py` | #177 | Medium — migrate to `compute_effect_bootstrap_stats` from `bootstrap_utils.py` |
| EfficientDiD: warn when cohort share is very small (< 2 units or < 1% of sample) — inverted in Omega*/EIF | `efficient_did_weights.py` | #192 | Low |
| EfficientDiD: API docs / tutorial page for new public estimator | `docs/` | #192 | Medium |
| TripleDifference power: `generate_ddd_data` is a fixed 2×2×2 cross-sectional DGP — no multi-period or unbalanced-group support. Add a `generate_ddd_panel_data` for panel DDD power analysis. | `prep_dgp.py`, `power.py` | #208 | Low |

#### Performance

Expand Down
8 changes: 8 additions & 0 deletions diff_diff/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,11 +53,15 @@
from diff_diff.power import (
PowerAnalysis,
PowerResults,
SimulationMDEResults,
SimulationPowerResults,
SimulationSampleSizeResults,
compute_mde,
compute_power,
compute_sample_size,
simulate_mde,
simulate_power,
simulate_sample_size,
)
from diff_diff.pretrends import (
PreTrendsPower,
Expand Down Expand Up @@ -291,11 +295,15 @@
# Power analysis
"PowerAnalysis",
"PowerResults",
"SimulationMDEResults",
"SimulationPowerResults",
"SimulationSampleSizeResults",
"compute_mde",
"compute_power",
"compute_sample_size",
"simulate_mde",
"simulate_power",
"simulate_sample_size",
"plot_power_curve",
# Pre-trends power analysis
"PreTrendsPower",
Expand Down
Loading
Loading