refactor(passport): BSB-6: remove StarkEx support from Passport SDK#2808
Open
naveen-imtb wants to merge 9 commits intomainfrom
Open
refactor(passport): BSB-6: remove StarkEx support from Passport SDK#2808naveen-imtb wants to merge 9 commits intomainfrom
naveen-imtb wants to merge 9 commits intomainfrom
Conversation
Remove all StarkEx/IMX provider code from the Passport SDK package. This is a breaking change - connectImx() and connectImxSilent() public methods are removed, and PassportOverrides no longer accepts IMX-specific fields (imxPublicApiDomain, immutableXClient, imxApiClients). Deleted: starkEx/ directory (provider, factory, guardian client, workflows), utils/imxUser.ts, and all associated tests. Simplified linkExternalWallet() to use isUserZkEvm() instead of toUserImx().
|
View your CI Pipeline Execution ↗ for commit c682840
☁️ Nx Cloud last updated this comment at |
Remove withPassportError, isAPIError re-exports from passportError.ts and AuthEvents, WalletEvents re-exports from types.ts — these were only consumed by the deleted StarkEx code and caused CI bundle warnings about unused imports from external modules.
Add local process type declaration in logger.ts to fix TS2580 error during typegen (pre-existing issue exposed by Nx cache invalidation).
Remove imxPublicApiDomain, imxApiClients, immutableXClient from overrides in sdk-sample-app and game-bridge, and clean up unused imports (IMXClient, ImxApiClients, createConfig, xClient).
Delete entire components/imx/ directory (8 files), remove connectImx, imxProvider, sdkClient, and all IMX-related imports/state/UI from PassportProvider, ImmutableProvider, index page, and Status component. Remove @imtbl/x-client and @imtbl/x-provider dependencies.
Regenerate pnpm-lock.yaml to match sdk-sample-app package.json changes that removed @imtbl/x-client and @imtbl/x-provider dependencies.
This example app is entirely dependent on connectImx() and IMXProvider which were removed as part of StarkEx cleanup. The app has no value without IMX/StarkEx functionality.
naveen-imtb
changed the title
Remove @imtbl/x-client from game-bridge and passport/sdk package.json, and @imtbl/x-provider from passport/sdk — neither package imports these modules after StarkEx code removal.
Skip starkCurve legacy key generation tests and IMXClient production test that make live HTTP calls to https://api.x.immutable.com. These are flaky in CI and the entire x-client package is deprecated as part of StarkEx cleanup.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
type(scope): message!after scopeSummary
Remove all StarkEx/IMX provider code from the Passport SDK, completing the SDK-side cleanup for the Guardian StarkEx deprecation (BSB-6).
Detail and impact of the change
Removed
connectImx()andconnectImxSilent()public methods from thePassportclassstarkEx/directory:PassportImxProvider,PassportImxProviderFactory,ImxGuardianClient,getStarkSigner, and all StarkEx workflows (transfer, order, trades, exchange, registration)utils/imxUser.ts(toUserImxhelper andUserImxtype)imxPublicApiDomain,immutableXClient,imxApiClientsfields fromPassportOverridesinterfaceimxPublicApiDomainproperty fromPassportConfigurationIMXProvider,IMXClient,ImxApiClients,imxApiConfig,MagicTeeApiClients,createConfigChanged
linkExternalWallet()now usesisUserZkEvm(user)instead of the removedtoUserImx()helper to check registration statusbuildPrivateVars()simplified to only create Auth — all IMX setup (WalletConfiguration for IMX GuardianClient, MagicTEESigner, ImxApiClients, PassportImxProviderFactory) removedAnything else worth calling out?
Breaking change: This removes the
connectImx()andconnectImxSilent()public API methods and modifies thePassportOverridespublic interface. Consumers using StarkEx/IMX through Passport will need to migrate.All zkEVM/multi-rollup functionality is unaffected —
connectEvm(), auth methods,linkExternalWallet(), andgetLinkedAddresses()work as before. The removed imports (WalletConfiguration,GuardianClient,MagicTEESigner,ConfirmationScreen) were exclusively used in the IMX setup path withinbuildPrivateVars; the zkEVM flow usesconnectWallet()which creates these internally.21 files changed, 8 insertions, 1,688 deletions. All 23 tests pass, lint clean.