CROSSLINK-231 last action info by adamdickmeiss · Pull Request #466 · indexdata/crosslink

adamdickmeiss · 2026-03-17T15:05:21Z

https://index-data.atlassian.net/browse/CROSSLINK-231

Extend the patron_request structure with last_action, last_action_outcome, last_action_result. Not populated yet with any values.

Copilot

Pull request overview

Adds database support for capturing “last action” metadata on patron requests, with corresponding query and API schema updates to surface these fields through the broker’s Patron Request model.

Changes:

Adds last_action, last_action_outcome, and last_action_result columns to patron_request (schema + migration).
Updates patron request create/update SQL and the CQL-backed list scanning to include the new columns.
Extends the OpenAPI PatronRequest schema with the new fields.

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
broker/sqlc/pr_schema.sql	Extends `patron_request` table definition with last-action columns.
broker/sqlc/pr_query.sql	Persists last-action columns in Create/Update queries.
broker/patron_request/db/prcql.go	Updates CQL list scan order to include new columns.
broker/oapi/open-api.yaml	Documents new PatronRequest fields in the API schema.
broker/migrations/019_last_action.up.sql	Migration to add new patron_request columns.
broker/migrations/019_last_action.down.sql	Rollback migration to drop the new columns.

You can also share your feedback on Copilot code review. Take the survey.

broker/migrations/019_last_action.down.sql

broker/oapi/open-api.yaml

broker/sqlc/pr_query.sql

broker/migrations/019_last_action.up.sql

Copilot

Pull request overview

Adds “last action” metadata to Patron Requests so API consumers can see the most recent executed action and its outcome/status, supporting CROSSLINK-231 (first part).

Changes:

Extend patron_request schema + migrations with last_action, last_action_outcome, last_action_result.
Populate these fields when actions are finalized, and expose them via the Patron Request API + OpenAPI schema.
Update CQL list scanning and add/extend API tests to assert the new fields.

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
broker/test/patron_request/api/api-handler_test.go	Adds assertions for last-action fields and adjusts expectations around a failing blocking action.
broker/sqlc/pr_schema.sql	Adds new patron_request columns to sqlc schema.
broker/sqlc/pr_query.sql	Updates Create/Update queries to include last-action columns.
broker/patron_request/service/action.go	Sets last-action fields during action finalization.
broker/patron_request/db/prcql.go	Extends manual `rows.Scan` to include the new columns.
broker/patron_request/api/api-handler.go	Maps new DB fields into API PatronRequest response.
broker/oapi/open-api.yaml	Documents last-action fields on PatronRequest schema.
broker/migrations/019_last_action.up.sql	Migration to add last-action columns.
broker/migrations/019_last_action.down.sql	Rollback migration to drop last-action columns.

You can also share your feedback on Copilot code review. Take the survey.

broker/test/patron_request/api/api-handler_test.go

broker/patron_request/service/action.go

Copilot

Pull request overview

Adds “last action” tracking to Patron Requests so the system can persist and expose the most recent executed action along with its outcome and event status.

Changes:

Add last_action, last_action_outcome, last_action_result columns to patron_request (schema + migration) and wire them into sqlc create/update/list queries.
Persist last-action metadata on every action execution and expose it via the PatronRequest API + OpenAPI schema.
Extend CRUD API tests to assert last-action fields after create/action execution.

Reviewed changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
broker/test/patron_request/api/api-handler_test.go	Adds assertions for last action/outcome/result after create and after executing actions.
broker/sqlc/pr_schema.sql	Extends `patron_request` table definition with last-action columns.
broker/sqlc/pr_query.sql	Updates Create/Update queries to include last-action fields.
broker/patron_request/service/action_mapping.go	Refactors action-availability helpers; adds logic intended to filter auto-actions based on failure.
broker/patron_request/service/action.go	Persists last-action fields during action finalization (always updates PR).
broker/patron_request/db/prcql.go	Updates manual `rows.Scan` mapping to include last-action columns.
broker/patron_request/api/api-handler.go	Maps last-action fields into API responses; documents that they’re unset at creation time.
broker/oapi/open-api.yaml	Adds lastAction/lastActionOutcome/lastActionResult to the PatronRequest schema.
broker/migrations/019_last_action.up.sql	Migration adding last-action columns.
broker/migrations/019_last_action.down.sql	Rollback migration dropping last-action columns.

You can also share your feedback on Copilot code review. Take the survey.

broker/migrations/019_last_action.up.sql

broker/migrations/019_last_action.down.sql

broker/patron_request/service/action_mapping.go

broker/oapi/open-api.yaml

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Adds persisted “last action” metadata to patron requests so API consumers can see the most recent workflow action and its outcome/status, aligning runtime behavior with CROSSLINK-231.

Changes:

Adds last_action, last_action_outcome, last_action_result columns (schema + migration) and wires them through sqlc queries and CQL scanning.
Persists last action info on every executed action and exposes the fields in the PatronRequest API + OpenAPI schema.
Extends API integration tests to assert last-action fields after key actions.

Reviewed changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
broker/test/patron_request/api/api-handler_test.go	Adds assertions verifying last action/outcome/result in API responses.
broker/sqlc/pr_schema.sql	Extends `patron_request` table schema with last-action columns.
broker/sqlc/pr_query.sql	Updates insert/update queries to include last-action columns.
broker/patron_request/service/action_mapping.go	Adjusts action listing/availability logic with awareness of last action result.
broker/patron_request/service/action.go	Updates action finalization to persist last-action metadata on patron requests.
broker/patron_request/db/prcql.go	Updates manual `rows.Scan` order to match new patron_request column order.
broker/patron_request/api/api-handler.go	Maps last-action fields into API PatronRequest responses.
broker/oapi/open-api.yaml	Documents lastAction/lastActionOutcome/lastActionResult in OpenAPI.
broker/migrations/019_last_action.up.sql	Migration adding last-action columns.
broker/migrations/019_last_action.down.sql	Migration removing last-action columns.

You can also share your feedback on Copilot code review. Take the survey.

broker/patron_request/service/action_mapping.go

broker/patron_request/api/api-handler.go

Copilot

Pull request overview

Adds “last action” metadata to patron requests so API consumers can see the most recent action name, outcome, and event status for a request (CROSSLINK-231).

Changes:

Add last_action, last_action_outcome, last_action_result columns to patron_request (schema + migration) and include them in sqlc queries/CQL scanning.
Persist last-action fields during action execution and expose them via the Patron Request API + OpenAPI schema.
Extend API integration tests to assert last-action fields are returned/updated.

Reviewed changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
broker/test/patron_request/api/api-handler_test.go	Asserts last-action fields in CRUD flow and after executing actions.
broker/sqlc/pr_schema.sql	Adds last-action columns to the patron_request table definition used by sqlc.
broker/sqlc/pr_query.sql	Updates Create/Update queries to include last-action columns.
broker/patron_request/service/action_mapping.go	Changes action availability logic to optionally include auto actions after failures, using last-action fields.
broker/patron_request/service/action.go	Persists last-action fields on every action finalization via UpdatePatronRequest.
broker/patron_request/db/prcql.go	Updates manual rows.Scan arg list to match new patron_request column order.
broker/patron_request/api/api-handler.go	Re-reads PR after auto-actions so response includes updated last-action fields; maps new fields to API model.
broker/oapi/open-api.yaml	Documents lastAction/lastActionOutcome/lastActionResult on PatronRequest.
broker/migrations/019_last_action.up.sql	Adds last-action columns to patron_request at runtime.
broker/migrations/019_last_action.down.sql	Removes last-action columns on rollback.

You can also share your feedback on Copilot code review. Take the survey.

broker/patron_request/service/action_mapping.go

broker/test/patron_request/api/api-handler_test.go

Copilot

Pull request overview

Adds end-to-end support for tracking the most recent action performed on a patron request (action name, outcome, and status), persisting it in Postgres and exposing it via the PatronRequest API.

Changes:

Add last_action, last_action_outcome, last_action_result columns + migration and sqlc query updates.
Persist last-action fields on every action finalization and expose them in API responses/OpenAPI.
Update action availability logic to optionally include auto-actions after a failed last action; extend tests accordingly.

Reviewed changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
broker/test/patron_request/api/api-handler_test.go	Extends integration CRUD test assertions to validate last-action fields across POST and action execution.
broker/sqlc/pr_schema.sql	Adds last-action columns to `patron_request` table schema definition.
broker/sqlc/pr_query.sql	Updates Create/Update queries to include last-action columns.
broker/patron_request/service/action_mapping_test.go	Adds coverage for GetActionsForPatronRequest behavior with/without state model and for failed last action.
broker/patron_request/service/action_mapping.go	Computes available actions based on state model + last action failure status (incl. auto-action handling).
broker/patron_request/service/action.go	Ensures last-action fields are updated and persisted on every action execution finalization.
broker/patron_request/db/prcql.go	Updates manual `rows.Scan` to match new column order (including last-action fields).
broker/patron_request/api/api-handler.go	Re-fetches PR after auto-actions and maps last-action fields into API model.
broker/oapi/open-api.yaml	Documents lastAction/lastActionOutcome/lastActionResult fields on PatronRequest.
broker/migrations/019_last_action.up.sql	Adds last-action columns via migration.
broker/migrations/019_last_action.down.sql	Drops last-action columns via rollback migration.

You can also share your feedback on Copilot code review. Take the survey.

broker/test/patron_request/api/api-handler_test.go

 	respBytes = httpRequest(t, "POST", thisPrPath+"/action"+queryParams, actionBytes, 200)
+	// used to succeed, but the illmock currently does not include items as part of the Loaned message, which causes the action to fail.
+	// We should either update the mock to include items or change the test to not use blocking action.
 	assert.Equal(t, "{\"actionResult\":\"ERROR\"}\n", string(respBytes))

+	respBytes = httpRequest(t, "GET", thisPrPath+queryParams, []byte{}, 200)
+	err = json.Unmarshal(respBytes, &foundPr)
+	assert.NoError(t, err, "failed to unmarshal patron request")
+	assert.Equal(t, *newPr.Id, foundPr.Id)
+	assert.Equal(t, "receive", *foundPr.LastAction)
+	assert.Equal(t, "failure", *foundPr.LastActionOutcome)
+	assert.Equal(t, "ERROR", *foundPr.LastActionResult)


jakub-id · 2026-03-19T16:39:36Z

broker/patron_request/api/api-handler.go

 			return
 		}
 	}
+	pr, err = a.prRepo.GetPatronRequestById(ctx, pr.ID)


@adamdickmeiss it would be more clear if RunAutoActionsOnStateEntry returned an updated version of pr

jakub-id · 2026-03-19T18:13:51Z

broker/patron_request/service/action_mapping.go

 	return r.SMService
 }

+type ActionEntry struct {


@adamdickmeiss could we rename this to PatronRequestAction and the string to ActionName

adamdickmeiss added 3 commits March 17, 2026 13:15

CROSSLINK-231 last_action

ce3f220

Extend the patron_request structure with last_action, last_action_outcome, last_action_result. Not populated yet with any values.

Comment

3cb4ea5

Populate action stuff and return it

570bf55

adamdickmeiss requested a review from jakub-id as a code owner March 17, 2026 15:05

Copilot AI review requested due to automatic review settings March 17, 2026 15:05

adamdickmeiss requested a review from JanisSaldabols as a code owner March 17, 2026 15:05

adamdickmeiss marked this pull request as draft March 17, 2026 15:05

Copilot started reviewing on behalf of adamdickmeiss March 17, 2026 15:05 View session

Merge branch 'main' into CROSSLINK-231-last-action-stuff

592c5e5

Copilot AI reviewed Mar 17, 2026

View reviewed changes

broker/migrations/019_last_action.down.sql Outdated Show resolved Hide resolved

broker/oapi/open-api.yaml Outdated Show resolved Hide resolved

broker/sqlc/pr_query.sql Show resolved Hide resolved

broker/migrations/019_last_action.up.sql Outdated Show resolved Hide resolved

adamdickmeiss added 3 commits March 17, 2026 17:26

testing

00aef24

comment

6858a4b

Merge branch 'main' into CROSSLINK-231-last-action-stuff

dad770e

adamdickmeiss requested a review from Copilot March 18, 2026 13:53

Copilot started reviewing on behalf of adamdickmeiss March 18, 2026 13:53 View session

Copilot AI reviewed Mar 18, 2026

View reviewed changes

broker/test/patron_request/api/api-handler_test.go Show resolved Hide resolved

broker/patron_request/service/action.go Show resolved Hide resolved

adamdickmeiss added 3 commits March 18, 2026 17:01

GetActionsForPatronRequest considers Auto, LastAction

64f6994

Persist also on lastAction change

933fe8d

Remove persistPr logic (always updates)

7520f8f

adamdickmeiss requested a review from Copilot March 18, 2026 16:17

Copilot started reviewing on behalf of adamdickmeiss March 18, 2026 16:18 View session

Merge branch 'main' into CROSSLINK-231-last-action-stuff

fd43b2a

adamdickmeiss marked this pull request as ready for review March 18, 2026 16:22

Copilot AI reviewed Mar 18, 2026

View reviewed changes

adamdickmeiss and others added 3 commits March 18, 2026 17:34

Potential fix for pull request finding

25747a9

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Potential fix for pull request finding

f00f49f

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Potential fix for pull request finding

cdc391f

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

adamdickmeiss marked this pull request as draft March 18, 2026 17:15

adamdickmeiss added 2 commits March 19, 2026 09:28

Fix GetActionsForPatronRequest

eeee5a9

Merge branch 'CROSSLINK-231-2' into CROSSLINK-231-last-action-stuff

7bfc8af

Merge branch 'main' into CROSSLINK-231-last-action-stuff

73c9aca

adamdickmeiss requested a review from Copilot March 19, 2026 08:51

Copilot AI reviewed Mar 19, 2026

View reviewed changes

adamdickmeiss added 4 commits March 19, 2026 10:02

Rename

29c726b

Re-read patron request as lastAction may be modified

058798c

IsActionAvailable based on new logic

796eafc

hasFailed

7930654

adamdickmeiss requested a review from Copilot March 19, 2026 09:25

Copilot AI reviewed Mar 19, 2026

View reviewed changes

broker/patron_request/service/action_mapping.go Outdated Show resolved Hide resolved

broker/test/patron_request/api/api-handler_test.go Show resolved Hide resolved

adamdickmeiss added 2 commits March 19, 2026 11:20

Fixes

6e4ff2f

Check empty

1fb6edc

adamdickmeiss requested a review from Copilot March 19, 2026 10:25

Copilot AI reviewed Mar 19, 2026

View reviewed changes

adamdickmeiss marked this pull request as ready for review March 19, 2026 10:50

JanisSaldabols approved these changes Mar 19, 2026

View reviewed changes

Treat PROBLEM as failed too

73df15e

adamdickmeiss requested a review from JanisSaldabols March 19, 2026 12:05

Use ActionMapping for something useful

4fd3529

jakub-id reviewed Mar 19, 2026

View reviewed changes

Conversation

adamdickmeiss commented Mar 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

jakub-id Mar 19, 2026

Choose a reason for hiding this comment

Uh oh!

jakub-id Mar 19, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

4 participants

adamdickmeiss commented Mar 17, 2026 •

edited

Loading