feat: restore signet binary alongside signet-exex and signet-sidecar#86
Open
feat: restore signet binary alongside signet-exex and signet-sidecar#86
Conversation
Fraser999
reviewed
Apr 2, 2026
rswanson
approved these changes
Apr 2, 2026
Add the original signet node binary back alongside signet-exex and signet-sidecar, creating a three-binary workspace. Update CI workflows to build/push all three, bump versions to rc.9, pin node-components to release tags, and rewrite README. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
prestwich
force-pushed
the
prestwich/eng-2118-three-binaries
branch
from
6a78872 to
bfcd916
Compare
Fraser999
requested changes
Apr 3, 2026
- Fix GHCR digest artifact name collision where `digests-signet-*`
pattern matched signet-exex and signet-sidecar artifacts, producing
broken multi-platform images. Use double-dash delimiters instead.
- Add `*/v**` tag trigger to ECR workflow for `<binary>/v<version>` tags.
- Remove duplicate COPY line in Dockerfile.
- Fix typo in doc comment ("State" → "Start").
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Fraser999
approved these changes
Apr 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes ENG-2118
signet,signet-exex,signet-sidecarsignetretains original code and deps (node-componentsv0.16.0, rethv1.11.3)signet-exexis the reth ExEx binary (node-components git tagv0.17.0, rethv1.11.0)signet-sidecaris the standalone RPC follower (node-components crates.io0.17, zero reth deps)1.0.0-rc.9CLAUDE.mdwith versioning, tagging, release, and dependency conventionsDependency strategy
v0.16.0v0.17.0(includes git-onlysignet-host-reth; using a single source avoids duplicate crate versions)"0.17"(no git-only deps)0.19across all threeinit4tech/node-componentswithin a single binaryNote on reth versions
signet-exexuses rethv1.11.0because node-componentsv0.17.0is pinned to that version.signetuses rethv1.11.3matching node-componentsv0.16.0.Test plan
cargo clippy -p signet --all-targetspassescargo clippy -p signet-exex --all-targetspassescargo clippy -p signet-sidecar --all-targetspassescargo +nightly fmtclean🤖 Generated with Claude Code