Conversation
Minor bump for the broadened loginUserWithUserAttributes TypeScript signature (now accepts full UserAttributes, not just email/userId). Updates README docs to match the new API surface. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
liutingdu
approved these changes
Mar 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why?
PR #391 broadened the
loginUserWithUserAttributesTypeScript signature fromPick<UserAttributes, 'email' | 'userId'>to fullUserAttributes, and fixed the Android implementation to actually pass all attributes. This is a public API change warranting a minor version bump, and the README documentation for this method was outdated.How?
Bump version to 9.8.0 and expand the
loginUserWithUserAttributesREADME section to document all supported user attribute fields, matching the existingupdateUserdocumentation pattern.Implementation Plan
Release 9.8.0
Context
Since 9.7.1, PR #391 fixed
loginUserWithUserAttributeson Android to actually pass all user attributes (not just email/userId) and broadened the TypeScript signature fromPick<UserAttributes, 'email' | 'userId'>to fullUserAttributes. This is a public API change warranting a minor version bump. The README documentation for this method is outdated and only showsemail/userId.Changes
1. Bump version in
package.json(line 3)"9.7.1"→"9.8.0"android/build.gradleread from this dynamically — no other version files need editing.2. Update README
loginUserWithUserAttributessection (lines 831–846)Replace the current minimal docs with expanded documentation matching the
updateUserpattern (lines 850–900):({email,userId})→(userAttributes)updateUserexample)UserAttributesfields (email, userId, name, phone, languageOverride, signedUpAt, unsubscribedFromEmails, companies, customAttributes)emailoruserIdis required3. Update
examples/example/ios/Podfile.lockcd examples/example/ios && pod installto regenerate with the new version string (line 8) and checksum (line 1336)9.7.1→9.8.0on line 84. Update
examples/with-notifications/ios/Podfile.lockintercom-react-native (9.7.1)→intercom-react-native (9.8.0)on line 12pod installwon't pick up the local version — following established pattern from prior releases)Files to modify
package.json— version bumpREADME.md— expandloginUserWithUserAttributesdocs (lines 831–846)examples/example/ios/Podfile.lock— version + checksum viapod installexamples/with-notifications/ios/Podfile.lock— version string (line 12)Verification
package.jsonshows"version": "9.8.0"pod installinexamples/example/ios/— should succeed and update the lock fileintercom-react-native (9.8.0)loginUserWithUserAttributessection matchesupdateUserstyleyarn typescript(ornpx tsc --noEmit) to confirm no type errorsGenerated with Claude Code