Open
Conversation
Yannicked
requested review from
SimonPinches,
deepakmaroo,
maarten-ic and
olivhoenen
as code owners
maarten-ic
reviewed
Mar 26, 2026
pyproject.toml
Outdated
| "pytest-cov>=5.0.0", | ||
| "ruff>=0.15.0", | ||
| "ty>=0.0.13", | ||
| "ruff==0.15.7", |
Collaborator
There was a problem hiding this comment.
Ruff should be stable within minor releases, so maybe you'd want this instead?
Suggested change
| "ruff==0.15.7", | |
| "ruff~=0.15.0", |
Contributor
There was a problem hiding this comment.
Do we need to be this precise? I ask since the version of ruff that comes packaged with EB 2025b toolchains is 0.14.3. (But maybe this is only ever used as part of a developer's venv and it's not an issue for central installations).
Collaborator
Author
There was a problem hiding this comment.
Ruff will only be installed as part of the dev dependency group, so this shouldn't be an issue for central installations
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pin ruff and ty versions. This resolves the current issues in the develop branch and prevents similar dependency-related regressions going forward