Skip to content

gitk: spanish translations#43

Open
basuradeluis wants to merge 1 commit intoj6t:masterfrom
basuradeluis:spanish_pr_bis
Open

gitk: spanish translations#43
basuradeluis wants to merge 1 commit intoj6t:masterfrom
basuradeluis:spanish_pr_bis

Conversation

@basuradeluis
Copy link
Copy Markdown

@basuradeluis basuradeluis commented Apr 1, 2026

PR redone over top master. filter clean setup as make command indicates.
Poeditor program used.

@j6t
Copy link
Copy Markdown
Owner

j6t commented Apr 1, 2026

Thanks. I notice that there are a few new fuzzy translations as well as new untranslated texts. Is there a reason not to translate them?

BTW, please force-push this branch after amending the old commit. Do not make a new PR.

@basuradeluis basuradeluis marked this pull request as draft April 12, 2026 20:15
@j6t
Copy link
Copy Markdown
Owner

j6t commented Apr 12, 2026

Thank you. Please squash all changes into one and force-push the branch.

When I build with this branch merged, I see:

Generating catalog po/es.msg
msgfmt --statistics --tcl -l es -d po/ po/es.po
303 translated messages, 26 untranslated messages.

Notice that there are still untranslated messages. If this is deliberate, please mention it in the commit message. Otherwise, I am pretty certain that Poedit has an command to find the next untranslated message.

Signed-off-by: basuradeluis <basuradeluis@gmail.com>
@basuradeluis
Copy link
Copy Markdown
Author

basuradeluis commented Apr 19, 2026

Translated all messages.
At the end of the file, some lines have appeared with commented messages. They appeared after running "make ALL_POFILES=po/es.po update-po" even in master branch, so maybe related with that command, not with translation. I suspect they are old messages that were removed from code.
Ready

Update: I have read in internet(/AI) that those are old entries. I can remove them if you want, poedit program I am using (by first time) has a "purge unused translations", that would remove those lines at the end. Including the ones that were before my translation. As you wish.

@basuradeluis basuradeluis marked this pull request as ready for review April 19, 2026 19:09
@j6t
Copy link
Copy Markdown
Owner

j6t commented Apr 19, 2026

I think that these commented-out translations can be used to seed future translations. Whether to leave them in or to remove them is a decision to be made by the translators.

I think I'll pick up this round. But please, for the next contribution, set your name to your legal name so that it need not be deciphered from the email address (and other clues in this patch).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants