Add support for sanitizers in cmake script and in CI#49
Open
Conversation
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+36
to
+37
| `./scripts/cmake.sh --asan` or `--tsan`). Note that ASAN, TSAN, and MSAN | ||
| are mutually exclusive. |
There was a problem hiding this comment.
This section states “ASAN, TSAN, and MSAN are mutually exclusive”, but the build entrypoint currently allows combining flags (e.g. --asan --tsan) and CMake doesn’t reject it. Either enforce mutual exclusivity in scripts/cmake.py/CMake configure (preferred), or adjust this guidance to match the actual supported combinations.
Suggested change
| `./scripts/cmake.sh --asan` or `--tsan`). Note that ASAN, TSAN, and MSAN | |
| are mutually exclusive. | |
| `./scripts/cmake.sh --asan` or `--tsan`). While the build entrypoint | |
| currently allows multiple sanitizer flags, only one of `--asan`, `--tsan`, | |
| or `--msan` should be used per invocation; combinations are not a supported | |
| configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.