Skip to content

fix(siriusxm): remove unused request-promise import#916

Open
garrettwinder wants to merge 1 commit intojishi:masterfrom
garrettwinder:worktree-agent-a5b04abd
Open

fix(siriusxm): remove unused request-promise import#916
garrettwinder wants to merge 1 commit intojishi:masterfrom
garrettwinder:worktree-agent-a5b04abd

Conversation

@garrettwinder
Copy link
Copy Markdown

Summary

  • Remove the unused request-promise import from lib/actions/siriusXM.js.
  • The request variable was never referenced anywhere in the file, so the import was dead code.
  • request-promise is pinned to ^0.0.1, a long-abandoned package whose main field points to a missing lib/tp.js. Because lib/helpers/require-dir.js loads every file under lib/actions at startup, this broken require was crashing node server.js on startup.

Test plan

  • Confirmed lib/actions/siriusXM.js loads cleanly when request-promise resolution is blocked:
    node -e "const M=require('module');const o=M._resolveFilename;M._resolveFilename=function(r,...a){if(r==='request-promise')throw new Error('blocked');return o.call(this,r,...a)};require('./lib/actions/siriusXM.js');console.log('OK')"
    
  • Note: two other files (musicSearch.js, spotifyDef.js) also require request-promise and are being fixed in parallel PRs. node server.js will continue to crash until all three are merged.

Co-Authored-By: Claude Opus 4.6 (1M context) noreply@anthropic.com

The request variable from request-promise was never used anywhere in
this file. request-promise is broken (pinned to ^0.0.1, a long-abandoned
package whose main field points to a missing lib/tp.js), which caused
node server.js to crash at startup because lib/helpers/require-dir.js
loads every file under lib/actions.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant