fix(siriusxm): remove unused request-promise import#916
Open
garrettwinder wants to merge 1 commit intojishi:masterfrom
Open
fix(siriusxm): remove unused request-promise import#916garrettwinder wants to merge 1 commit intojishi:masterfrom
garrettwinder wants to merge 1 commit intojishi:masterfrom
Conversation
The request variable from request-promise was never used anywhere in this file. request-promise is broken (pinned to ^0.0.1, a long-abandoned package whose main field points to a missing lib/tp.js), which caused node server.js to crash at startup because lib/helpers/require-dir.js loads every file under lib/actions. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
request-promiseimport fromlib/actions/siriusXM.js.requestvariable was never referenced anywhere in the file, so the import was dead code.request-promiseis pinned to^0.0.1, a long-abandoned package whosemainfield points to a missinglib/tp.js. Becauselib/helpers/require-dir.jsloads every file underlib/actionsat startup, this broken require was crashingnode server.json startup.Test plan
lib/actions/siriusXM.jsloads cleanly whenrequest-promiseresolution is blocked:musicSearch.js,spotifyDef.js) also requirerequest-promiseand are being fixed in parallel PRs.node server.jswill continue to crash until all three are merged.Co-Authored-By: Claude Opus 4.6 (1M context) noreply@anthropic.com