Open
Conversation
KuiMing
commented
Dec 13, 2015
- Comment out setting of column names because Data are not just "OHLC".
- Order by first element of "db.fields".
1. Comment out setting of column names because Data are not just "OHLC". 2. Order by first element of "db.fields".
Collaborator
|
I think you're going to need to describe your rationale for the change to order_by. The data pulled ultimately needs to be converted to xts, so some standardization is required on the order_by data. As for column names, I agree with the spirit that not all data is OHLCVA. I would suggest naming the columns for the columns in the SQLite data to start. Then, we could test for OHLC, BBO, etc using other functional already in quantmod for that purpose. Simply eliminating column name setting entirely doesn't seem like a general solution. |
Owner
|
Author
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.