Add RedshiftAdapter

[gronpipmaster]

Add support aws redshift

[jpfuentes2]

Is it possible to add tests for this?

[koenpunt]

If you make the RedshiftAdapter extend from PgsqlAdapter you only have to update the methods that differ from the original adapter. And you don't have to make changes to Table.php.

Also, your classfile uses spaces for indentation, where all other are using tabs.

[gronpipmaster]

@koenpunt Yes, I wanted to do in the beginning, but https://github.com/jpfuentes2/php-activerecord/blob/master/lib/Connection.php#L132-L140 you do not use Connection of adapters through the namespace and I get the error 'PHP Fatal error: Class 'ActiveRecord\PgsqlAdapter' not found in' if remodel Connection of, reverse compatibility, and will need quite a lot to refactor. If it makes sense to do.

@jpfuentes2 Aws Redshift is an internal service of the Amazon, and without an account can not get there. If you can run tests on the old version Postrges sql <= 8.0.2, I do.

[koenpunt]

If you require the PgsqlAdapter in RedshiftAdapter.php, that should fix PHP Fatal error: Class 'ActiveRecord\PgsqlAdapter' not found in

require_once __DIR__ . '/PgsqlAdapter.php';

[koenpunt]

now that RedshiftAdapter extends PgsqlAdapter, $this->conn instanceof PgsqlAdapter would be sufficient here

[gronpipmaster]

Accept?

[koenpunt]

To get this running on aws, I'll have to setup an ec2 and redshift instance? Or can it run standalone as well?

[gronpipmaster]

Only redshift instance, and I am currently using this adapter. Сonnection redshift://user:pass@host:port/base as to any of your adapter.

[koenpunt]

We should add instructions on how to test this on a live instance, otherwise if any of the code gets updated later, there is no way to verify that your adapter still works. But before that I think we should refactor the test setup (#475, #485)

[jpfuentes2]

Why not add the instructions now and merge then refactor the test setup afterwards? Couldn't we ignore the adapter by default unless given a specific command?

[koenpunt]

The adapter is ignored by default (afaik), because it's not included in the test/helpers/config.php

[jpfuentes2]

Ah, then should we still block this if @gronpipmaster adds some instructions?