fix: reject deletion of already-released leases#401
Open
raballew wants to merge 1 commit intojumpstarter-dev:mainfrom
Open
fix: reject deletion of already-released leases#401raballew wants to merge 1 commit intojumpstarter-dev:mainfrom
raballew wants to merge 1 commit intojumpstarter-dev:mainfrom
Conversation
DeleteLease now returns a FailedPrecondition error when attempting to delete a lease that has already been released, instead of silently re-patching it. Closes jumpstarter-dev#250 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
❌ Deploy Preview for jumpstarter-docs failed. Why did it fail? →
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DeleteLeasewas silently settingRelease=trueagain on leases that were already released, which is a no-op but misleading. Now it returns aFailedPreconditionerror if the lease was already released, so callers get clear feedback.Fixes #250
Test plan
🤖 Generated with Claude Code