feat: load VCR_SANITIZERS from component script during scaffold recording#7
Merged
matyas-jirat-keboola merged 6 commits intomainfrom Mar 19, 2026
Merged
Conversation
…affold recording Scaffold recording now calls _load_vcr_sanitizers_from_script (same as the replay path in tester.py) so component-defined sanitizers are applied consistently when cassettes are first recorded, not only on replay. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…ers are provided Previously, passing a non-None sanitizers list to VCRRecorder replaced the DefaultSanitizer entirely, so secrets from config.secrets.json were no longer redacted. Now DefaultSanitizer is always prepended, ensuring credentials are sanitized even when component-defined sanitizers are also active. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
… compat datetime.UTC was added in Python 3.11; the package requires >=3.10. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
ruff target-version was py313 while requires-python is >=3.10, causing UP017 to suggest datetime.UTC which is unavailable on Python 3.10/3.11. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
soustruh
approved these changes
Mar 19, 2026
soustruh
left a comment
soustruh
left a comment
There was a problem hiding this comment.
Week done, I appreciate all those code quality improvements! 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TestScaffolder._record_test()now calls_load_vcr_sanitizers_from_script(the same function used bytester.pyduring replay) so component-defined sanitizers (e.g. GCS signed URL redaction) are applied when cassettes are first recorded, not only on replay.DefaultSanitizer.mergerefactored; PEP 563 lazy annotations; pre-scan optimisation to skip interactions with no secrets._write_interactionrename.Test plan
python -m pytest tests/)VCR_SANITIZERSand verify the cassette output contains sanitized values🤖 Generated with Claude Code