Add timeout experimental feature to the spec#76
Add timeout experimental feature to the spec#76lionelvillard wants to merge 1 commit intoknative:mainfrom
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: lionelvillard The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
I think we may want to have a bit of a level-setting discussion here; the goal of the I suspect that we may want to remove the "update the spec" suggestion in the eventing template, as the goal is that the Knative spec evolves more slowly than the OSS implementation, which can make experimental and backwards-incompatible changes without requiring a new spec release and vendors to update their software in order to maintain conformance. |
|
/hold |
| <tr> | ||
| <td><code>timeout</code></td> | ||
| <td>string (OPTIONAL)</td> | ||
| <td>The timeout of each single request.</td> |
There was a problem hiding this comment.
This description should indicate what the acceptable values of the string are. Is "a score of fortnights" acceptable?
There was a problem hiding this comment.
Serving has a timeoutSeconds integer. Any particular reason to use a different type and name?
|
@pierDipi is this still relevant? |
Added timeout to the delivery spec. For more details: knative/eventing#5149