Merged
Conversation
Member
Author
|
SamBarker
reviewed
Mar 5, 2026
Member
SamBarker
left a comment
SamBarker
left a comment
There was a problem hiding this comment.
LGTM visually not quite sure about the content of the call out.
join-us/mailing-lists/index.md
Outdated
| <h1 id="page-title" class="fs-3">{{ page.title }}</h1> | ||
| <p>Join our Development Mailing List to keep up with:</p> | ||
| <ul> | ||
| <li>Formal technical discussions and proposals.</li> |
Member
There was a problem hiding this comment.
I'm wary of this point. Technical discussions yes, but proposals are better discussed on PR /GitHub side of the equation.
Member
Author
There was a problem hiding this comment.
Have removed the bit about proposals. Though I think mailing list could be appropriate for someone who wants to write an essay related to an open proposal, or is testing the waters before opening one.
We need instructions to tell people how to subscribe/unsubscribe from the development mailing list. Signed-off-by: Robert Young <robertyoungnz@gmail.com>
robobario
force-pushed
the
mailing-list-page
branch
from
a0bf0a3 to
bd661fa
Compare
tombentley
approved these changes
Mar 6, 2026
Member
tombentley
left a comment
tombentley
left a comment
There was a problem hiding this comment.
I think this looks good. One open question, but that could be added later. LGTM.
| <div> | ||
| <ul> | ||
| <li>If you have a Google Account, you can join <a href="https://groups.google.com/g/kroxylicious-dev">here</a></li> | ||
| <li>Alternatively, you can subscribe by sending an empty email to <a href="mailto:kroxylicious-dev+subscribe@googlegroups.com">kroxylicious-dev+subscribe@googlegroups.com</a></li> |
Member
There was a problem hiding this comment.
Should we explain how to send a message once subscribed?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We need instructions to tell people how to subscribe/unsubscribe from the development mailing list.
It is linked to from a new card on the join-us page