Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains suggested improvements to AI context files.
Summary
CLAUDE.mdFive issues found: (1) Missing security requirement for cryptographic secret keys refusing to start in production without a key. (2) Missing requirement to never log sensitive values in clear text — the 'use logging liberally' advice is actively dangerous without this caveat. (3) Missing requirement for authorization logic to be fully implemented. (4) Missing requirement to use a centralized constants file for enums. (5) The Best Practices code block uses deprecated typing imports (List, Optional) incompatible with the project's Python 3.13+ target, and is excessively verbose for what it conveys.
CONTRIBUTING.mdThe file is a developer-facing CONTRIBUTING.md that is missing any security or coding-standards guidance. It does not mention the three key requirements: (1) no clear-text logging of sensitive values, (2) SECRET_KEY must not silently fall back to an ephemeral value in production, and (3) enum constants must come from a centralized constants file. Additionally, the file is somewhat verbose with redundant bash examples. The suggested edit adds a concise Security guidelines section and restructures the content for skimmability.