Hash21 — Bitcoin Art Gallery with Lightning & On-Chain Certification#26
Hash21 — Bitcoin Art Gallery with Lightning & On-Chain Certification#26warrior-lai wants to merge 3 commits intolacrypta:mainfrom
Conversation
- 59 tests with Vitest - OpenAPI 3.0 documentation - User system with roles - Updated description
📝 WalkthroughWalkthroughThe PR reformats Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
data/projects/foundations.json (1)
426-429:backendis currently not surfaced in the UI.Line 427 adds useful metadata, but
hackathons/foundations.html(Lines 622-680) only rendersrepoanddemo, sobackendis silently ignored. Consider rendering a backend link or dropping the field if intentionally unused.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@data/projects/foundations.json` around lines 426 - 429, The JSON "backend" field in foundations.json is being added but not rendered by the hackathons/foundations.html template; update the template code that currently renders only "repo" and "demo" to also conditionally render a "backend" link (e.g., check item.backend and output an anchor with appropriate label/aria) or remove the "backend" key from the JSON if you prefer not to display it; ensure you update the same rendering block that references repo/demo so the backend URL is surfaced consistently across entries.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@data/projects/foundations.json`:
- Around line 454-459: The _instructions.optionalFields array is missing the
newly introduced "backend" field, causing a contract mismatch; update the JSON
under the _instructions.optionalFields key to include the string "backend"
alongside the existing entries ("repo", "demo", "tech", "submittedAt") so
contributors see that backend is optional—ensure you add the literal "backend"
value to the optionalFields array where optionalFields is defined.
---
Nitpick comments:
In `@data/projects/foundations.json`:
- Around line 426-429: The JSON "backend" field in foundations.json is being
added but not rendered by the hackathons/foundations.html template; update the
template code that currently renders only "repo" and "demo" to also
conditionally render a "backend" link (e.g., check item.backend and output an
anchor with appropriate label/aria) or remove the "backend" key from the JSON if
you prefer not to display it; ensure you update the same rendering block that
references repo/demo so the backend URL is surfaced consistently across entries.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: e2f3b102-a653-4c81-816a-41972c06d2e1
📒 Files selected for processing (1)
data/projects/foundations.json
| "optionalFields": [ | ||
| "repo", | ||
| "demo", | ||
| "tech", | ||
| "submittedAt" | ||
| ], |
There was a problem hiding this comment.
Add backend to documented optional fields.
Line 427 introduces backend, but Lines 454-459 don’t list it under _instructions.optionalFields. This creates a contributor-facing contract mismatch.
🛠 Proposed fix
"optionalFields": [
"repo",
+ "backend",
"demo",
"tech",
"submittedAt"
],📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| "optionalFields": [ | |
| "repo", | |
| "demo", | |
| "tech", | |
| "submittedAt" | |
| ], | |
| "optionalFields": [ | |
| "repo", | |
| "backend", | |
| "demo", | |
| "tech", | |
| "submittedAt" | |
| ], |
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@data/projects/foundations.json` around lines 454 - 459, The
_instructions.optionalFields array is missing the newly introduced "backend"
field, causing a contract mismatch; update the JSON under the
_instructions.optionalFields key to include the string "backend" alongside the
existing entries ("repo", "demo", "tech", "submittedAt") so contributors see
that backend is optional—ensure you add the literal "backend" value to the
optionalFields array where optionalFields is defined.
1 participant
Hash21
Plataforma de arte soberano sobre Bitcoin. Permanencia para la obra. Soberanía para el artista.
🔗 Links
✅ Features en Producción
🛠️ Stack
NIP-57 | LNURL-pay | Lightning Address | WebLN | Nostr (kind 9734/9735) | OpenTimestamps | Supabase | Vercel Serverless | Vitest (59 tests)
👥 Equipo
Summary by CodeRabbit
Release Notes