fix(ContainerPreview): Fix invisible text on preview#275
Open
IceTank wants to merge 1 commit intolambda-client:1.21.11from
Open
fix(ContainerPreview): Fix invisible text on preview#275IceTank wants to merge 1 commit intolambda-client:1.21.11from
IceTank wants to merge 1 commit intolambda-client:1.21.11from
Conversation
Fix luminance check making most shulker name text hard to read
Contributor
Author
|
fixes #254 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pr changes the luminance method. It replaces the magic number values with the Minecraft internal color values. The used magic values had zero alpha components and thus appeared invisible.
This PR also changes the luminance check on the text color to make the text in the preview windows easier to read.
Luminance comparison
Before:
After:
