Fix wire codec for multi-level extensible record chains#88
Open
dillonkearns wants to merge 1 commit intolamdera:lamdera-nextfrom
Open
Fix wire codec for multi-level extensible record chains#88dillonkearns wants to merge 1 commit intolamdera:lamdera-nextfrom
dillonkearns wants to merge 1 commit intolamdera:lamdera-nextfrom
Conversation
When an extensible record extends another extensible record
(e.g. `Level2 compatible = Level1 { compatible | field2 : Int }`),
the wire codec generator would only resolve one level of TAlias chain,
silently dropping fields from the outermost extension.
Adds `resolveToRecord` helper in Helpers.hs that recursively peels TAlias
layers until reaching a TRecord. Applied in both Encoder and Decoder Holey
branches where `resolveTvar` previously only matched a single TAlias layer.
Test: Wire_Record_Extensible6_TwoLevel.elm with two-level and three-level
extensible chains, plus a union wrapping both.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uncovered another wire codec issue from #87, here's a fix for it.
When an extensible record extends another extensible record (e.g.
Level2 compatible = Level1 { compatible | field2 : Int }), the wire codec generator would only resolve one level ofTAliaschain, silently dropping fields from the outermost extension.