Use identity/value for Bytes port encoding instead of lamdera/codecs#91
Open
MavenRain wants to merge 1 commit intolamdera:lamdera-nextfrom
Open
Use identity/value for Bytes port encoding instead of lamdera/codecs#91MavenRain wants to merge 1 commit intolamdera:lamdera-nextfrom
MavenRain wants to merge 1 commit intolamdera:lamdera-nextfrom
Conversation
The Bytes encoder and decoder for ports and flags referenced encodeBytes_/decodeBytes_ from lamdera/codecs, which crashes with Map.! when that package is absent. Since Bytes is a raw DataView in JS, no transformation is needed at the boundary: use Basics.identity for encoding and Json.Decode.value for decoding, matching how Json.Encode.Value is already handled. Fixes lamdera#26.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Bytes encoder and decoder for ports and flags referenced encodeBytes_/decodeBytes_ from lamdera/codecs, which crashes with Map.! when that package is absent. Since Bytes is a raw DataView in JS, no transformation is needed at the boundary: use Basics.identity for encoding and Json.Decode.value for decoding, matching how Json.Encode.Value is already handled. Fixes #26.