Allow configuring <html lang> via html-lang file#92
Open
MavenRain wants to merge 1 commit intolamdera:lamdera-nextfrom
Open
Allow configuring <html lang> via html-lang file#92MavenRain wants to merge 1 commit intolamdera:lamdera-nextfrom
MavenRain wants to merge 1 commit intolamdera:lamdera-nextfrom
Conversation
Read an optional html-lang file from the project root to set the lang attribute on the generated <html> tag. If the file contains e.g. "fr", the output becomes <html lang="fr">. If absent or empty, the tag is plain <html> as before. Fixes lamdera#84.
lydell
reviewed
Apr 1, 2026
| let trimmed = T.strip lang in | ||
| if T.null trimmed | ||
| then "<html>" | ||
| else "<html lang=\"" <> T.encodeUtf8Builder trimmed <> "\">" |
Contributor
There was a problem hiding this comment.
I think this should HTML-escape the value. Otherwise people will end up writing stuff like this in the file:
en" other-attribute="i want it" third="yes
Contributor
|
I don’t think this solves the problem fully. What if you have a multi-lingual Lamdera app where you can change the language? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Read an optional html-lang file from the project root to set the lang attribute on the generated tag. If the file contains e.g. "fr", the output becomes . If absent or empty, the tag is plain as before. Fixes #84.