fix: handle Channel.DoesNotExist in remove_self#5769
Open
ashnaaseth2325-oss wants to merge 1 commit intolearningequality:unstablefrom
Open
fix: handle Channel.DoesNotExist in remove_self#5769ashnaaseth2325-oss wants to merge 1 commit intolearningequality:unstablefrom
ashnaaseth2325-oss wants to merge 1 commit intolearningequality:unstablefrom
Conversation
Signed-off-by: ashnaaseth2325-oss <ashnaaseth2325@gmail.com>
|
👋 Thanks for contributing! We will assign a reviewer within the next two weeks. In the meantime, please ensure that:
We'll be in touch! 😊 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SUMMARY
This PR fixes an unhandled
Channel.DoesNotExistexception in theremove_selfview that caused a 500 error for invalidchannel_id. It ensures a proper 404 response is returned instead.Primary changes are in
contentcuration/contentcuration/viewsets/user.py.FIX
RESULT
channel_idnow returns 404 Not Found instead of 500