Switch to async background processing and cleanup runtime handling.#68
Merged
tnull merged 2 commits intolightningdevkit:mainfrom Apr 26, 2023
Merged
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #37~~, currently based on lightningdevkit/rust-lightning#2199.~~
We switch to an async BP as upstream now allows us to.
We furthermore cleanup our runtime handling:
So far we instantiated a dedicated
Runtimeobject which also held the BP. This was clunky and somewhat error-prone under different circumstances. As we now got rid of the BP object, we here remove the dedicatedRuntimeobject and just pass around anArc<RwLock<Option<Runtime>>>upon init, which allows us to get rid of theset/dropmethods onWalletas an added benefit.