LCORE-1496: Inference providers e2e tests failing (Watson, Vertex, Azure, RHAIIS, RHELAI)

[are-ces]

Description

Several issues are addressed in this PR:

• configuration of providers had breaking changes upstream (WatsonX, Azure)
• constants module was not visible in the enrichment script: added src to the PYTHONPATH
• Azure URL changed

Type of change

• Refactor
• New feature
• Bug fix
• CVE fix
• Optimization
• Documentation Update
• Configuration Update
• Bump-up service version
• Bump-up dependent library
• Bump-up library or tool used for development (does not change the final image)
• CI configuration change
• Konflux configuration change
• Unit tests improvement
• Integration tests improvement
• End to end tests improvement
• Benchmarks improvement

Tools used to create PR

Identify any AI code assistants used in this PR (for transparency and review context)

• Assisted-by: Claude

Related Tickets & Documents

• Related Issue # LCORE-1496
• Closes # LCORE-1496

Checklist before requesting a review

• I have performed a self-review of my code.
• PR has passed all pre-merge test jobs.
• If it is a core feature, I have added thorough tests.

Testing

e2e tests passing for the providers.

Summary by CodeRabbit

• New Features

  • Added Model Context Protocol (MCP) support enabling extended tool capabilities across all provider configurations

• Configuration & Storage

  • Updated storage backend structure for improved vector data persistence
  • Added new embedding model with enhanced semantic representation (768-dimensional)
  • Refreshed inference provider endpoint configurations for Azure and Watsonx integrations

[coderabbitai]

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 00f25851-6f15-46ee-9289-374b8802c3b8

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

Walkthrough

Configuration files for multiple LLM providers (Azure, VertexAI, WatsonX) and container runtime are updated to add Model Context Protocol (MCP) support, restructure storage backends, update embedding models from nomic to sentence-transformers, and standardize provider endpoint naming conventions (api_base/url → base_url).

Changes

Cohort / File(s)	Summary
Example Configurations examples/azure-run.yaml, examples/vertexai-run.yaml, examples/watsonx-run.yaml	Added MCP remote provider (model-context-protocol). Updated RAG persistence backend from kv_default to kv_rag. Restructured storage backends with explicit kv_rag (kv_sqlite) and updated kv_default paths. Added embedding model all-mpnet-base-v2 (sentence-transformers, 768 dimensions) and corresponding FAISS vector store registration. Changed default embedding model from nomic-ai/nomic-embed-text-v1.5 to all-mpnet-base-v2. Standardized provider endpoint field names (api_base/url → base_url for Azure and WatsonX). Removed telemetry section from VertexAI config.
Test E2E Configurations tests/e2e/configs/run-azure.yaml, tests/e2e/configs/run-vertexai.yaml, tests/e2e/configs/run-watsonx.yaml	Added MCP remote provider entry to tool_runtime. Standardized Azure provider endpoint from api_base to base_url with /openai/v1 path. Updated WatsonX provider from url to base_url. Added inline documentation comments for RAG tool runtime. Removed empty vector_stores array from WatsonX config.
Container Runtime test.containerfile	Added PYTHONPATH=/opt/app-root/src environment variable to container image alongside existing PATH modification for virtual environment activation.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title directly references the bug being fixed (LCORE-1496 and inference provider e2e test failures) and accurately reflects the main focus of the changeset, which updates configurations for multiple inference providers (Watson, Vertex, Azure, etc.) to fix failing tests.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)

tests/e2e/configs/run-watsonx.yaml (1)

157-162: ⚠️ Potential issue | 🔴 Critical

Duplicate vector_stores key will break vector store registration.

Same issue as in examples/watsonx-run.yaml - the vector_stores: [] at line 162 overwrites the FAISS configuration above it.

🐛 Proposed fix - remove the duplicate key

   vector_stores: 
   - embedding_dimension: 768
     embedding_model: sentence-transformers/all-mpnet-base-v2
     provider_id: faiss
     vector_store_id: ${env.FAISS_VECTOR_STORE_ID}
-  vector_stores: []
   datasets: []

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@tests/e2e/configs/run-watsonx.yaml` around lines 157 - 162, The YAML contains
a duplicate top-level key "vector_stores" which causes the configured FAISS
entry (the block with embedding_dimension, embedding_model, provider_id, and
vector_store_id) to be overwritten by the later empty `vector_stores: []`;
remove the trailing duplicate `vector_stores: []` so the FAISS configuration
block remains the sole "vector_stores" entry (same fix as in
examples/watsonx-run.yaml).

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@examples/watsonx-run.yaml`:
- Around line 157-162: The YAML contains a duplicate top-level key
"vector_stores" which causes the configured FAISS block (embedding_dimension,
embedding_model, provider_id, vector_store_id with ${env.FAISS_VECTOR_STORE_ID})
to be overwritten by the later "vector_stores: []"; remove the redundant
"vector_stores: []" entry so the FAISS vector store configuration remains (keep
the block containing embedding_dimension, embedding_model, provider_id,
vector_store_id).

---

Outside diff comments:
In `@tests/e2e/configs/run-watsonx.yaml`:
- Around line 157-162: The YAML contains a duplicate top-level key
"vector_stores" which causes the configured FAISS entry (the block with
embedding_dimension, embedding_model, provider_id, and vector_store_id) to be
overwritten by the later empty `vector_stores: []`; remove the trailing
duplicate `vector_stores: []` so the FAISS configuration block remains the sole
"vector_stores" entry (same fix as in examples/watsonx-run.yaml).

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 761aed89-4a09-46d4-b1c2-c76b08c57a02

📥 Commits

Reviewing files that changed from the base of the PR and between f814439 and e29492c.

📒 Files selected for processing (10)

• .github/workflows/e2e_tests_providers.yaml
• .github/workflows/e2e_tests_rhaiis.yaml
• .github/workflows/e2e_tests_rhelai.yaml
• examples/azure-run.yaml
• examples/vertexai-run.yaml
• examples/watsonx-run.yaml
• test.containerfile
• tests/e2e/configs/run-azure.yaml
• tests/e2e/configs/run-vertexai.yaml
• tests/e2e/configs/run-watsonx.yaml