TPT-4206: Integration tests for NB Front-End IP & 40Gbps#915
Merged
mawilk90 merged 22 commits intolinode:proj/nb-front-end-ip-in-vpcfrom Mar 23, 2026
Conversation
…cerWithFrontendVPC
Contributor
Author
|
There are two tests that check API error message in case of invalid nodebalancer's request body (similarly as it was in python SDK). I'm not sure what is the correct approach here so decided to leave them but comment them out (since they are expected to fail there is no fixtures for them at all) |
Contributor
There was a problem hiding this comment.
Pull request overview
Adds/updates integration tests to validate NodeBalancer behavior when using VPC front-end IPs (premium) and the premium_40gb NodeBalancer type, along with supporting test utilities and recorded fixtures.
Changes:
- Extend NodeBalancer integration tests to cover: backend-VPC-only, frontend-VPC-only (premium), frontend+backend in different VPCs, and
premium_40gb. - Update VPC creation helpers to select regions using
linodego.Capability*constants (and include NodeBalancer capability). - Add a generic
getIntersectionhelper and new VCR fixtures for the added test cases.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| test/integration/vpc_subnet_test.go | Adjusts region capability filtering for VPC creation helpers used by integration tests. |
| test/integration/util_test.go | Adds a generic slice intersection helper used for region selection. |
| test/integration/nodebalancers_test.go | Adds new NodeBalancer/VPC integration tests and setup helpers, plus region selection logic. |
| test/integration/fixtures/TestNodeBalancer_Create_WithBackendVPCOnly.yaml | New recorded fixture for backend-VPC-only NodeBalancer creation. |
| test/integration/fixtures/TestNodeBalancer_Create_WithFrontendVPCOnly.yaml | New recorded fixture for frontend-VPC-only (premium) NodeBalancer creation. |
| test/integration/fixtures/TestNodeBalancer_Create_WithFrontendAndBackendInDifferentVPCs.yaml | New recorded fixture for frontend+backend in different VPCs. |
| test/integration/fixtures/TestNodeBalancer_Create_WithPremium40gbType.yaml | New recorded fixture for premium_40gb NodeBalancer creation. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
dawiddzhafarov
approved these changes
Mar 19, 2026
ezilber-akamai
approved these changes
Mar 20, 2026
b352f40
into
linode:proj/nb-front-end-ip-in-vpc
10 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
Integration tests for NodeBalancer Front-End IP in VPC and 40Gbps NodeBalancer-MTC
NOTE:
There is no valid region on DevCloud to create nodebalancers of type=premium_40gb so one test will fail. I decided to do not add 'skipif' dependent on the env, because we usually do not execute tests on DevCloud
✔️ How to Test
make test-int TEST_ARGS="-run TestNodeBalancer_Create_With"