TPT-3807: Added DiskEncryption field for LKE Node Pool creation#917
Merged
ezilber-akamai merged 7 commits intolinode:mainfrom Mar 27, 2026
Merged
TPT-3807: Added DiskEncryption field for LKE Node Pool creation#917ezilber-akamai merged 7 commits intolinode:mainfrom
DiskEncryption field for LKE Node Pool creation#917ezilber-akamai merged 7 commits intolinode:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds DiskEncryption support to LKE node pool creation flows and updates integration coverage/fixtures to validate the new field.
Changes:
- Added
DiskEncryptiontoLKENodePoolCreateOptionsand propagated it throughGetCreateOptions. - Updated LKE node pool integration tests to create pools with disk encryption enabled and assert the returned value.
- Refreshed integration fixtures to include
disk_encryptionin request/response payloads.
Reviewed changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
lke_node_pools.go |
Extends node pool create options to include disk_encryption and propagates it from node pool objects. |
test/integration/lke_node_pools_test.go |
Enables disk encryption in node pool create options and asserts it on GET. |
test/integration/fixtures/TestLKENodePool_GetMissing.yaml |
Updates recorded headers for the missing-node-pool test. |
test/integration/fixtures/TestLKENodePool_GetFound_k8s.yaml |
Updates recorded Kubernetes /nodes response used by readiness polling. |
test/integration/fixtures/TestLKENodePool_CreateWithLabelsAndTaints.yaml |
Updates recorded LKE cluster/node pool create flows and responses. |
test/integration/fixtures/TestLKENodePoolNode_Recycle.yaml |
Updates recorded node pool/node recycle flow fixtures to include disk encryption. |
test/integration/fixtures/TestLKENodePoolNode_Get.yaml |
Updates recorded node pool/node get flow fixtures to include disk encryption. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
test/integration/fixtures/TestLKENodePool_CreateWithLabelsAndTaints.yaml
Outdated
Show resolved
Hide resolved
zliang-akamai
approved these changes
Mar 26, 2026
mawilk90
approved these changes
Mar 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
Added support for
DiskEncryptionfield in LKE Node Pool POST operation.✔️ How to Test
make test-int TEST_ARGS="-run TestLKENodePool"