Skip to content

fix: [UIE-10490, UIE-10564] - Mock relevant flags in alerts-related tests#13532

Merged
tvijay-akamai merged 4 commits intolinode:developfrom
pmakode-akamai:UIE-10490-mock-relevant-flags-in-alerts-related-tests
Mar 25, 2026
Merged

fix: [UIE-10490, UIE-10564] - Mock relevant flags in alerts-related tests#13532
tvijay-akamai merged 4 commits intolinode:developfrom
pmakode-akamai:UIE-10490-mock-relevant-flags-in-alerts-related-tests

Conversation

@pmakode-akamai
Copy link
Contributor

@pmakode-akamai pmakode-akamai commented Mar 25, 2026

Description 📝

This PR fixes inconsistencies in Cypress alert-related tests caused by missing feature flag mocks.

Previously, tests were only relying on aclpServices (linode -> beta/new) flags. While this was somehow passing in CI, it fails locally because aclpAlerting / aclp (beta/new) flags were not mocked, leading to inconsistent and buggy behavior.

This PR adds the required flag mocks and cleans up test related constants for better clarity.

Related PRs:

Changes 🔄

  • Added missing mocks for: aclpAlerting and aclp (beta/new) (Kept aclpServices flags as is to support contextual view)
  • Renamed tests constants for clearer distinction between:
    • legacy vs ACLP modes and beta vs new phases
  • Updated alerts-create tests to use the correct constants based on mocked flags

Scope 🚢

  • All customers
  • Some customers (e.g. in Beta or Limited Availability)
  • No customers / Not applicable

Target release date 🗓️

March End

Preview 📷

Before (dev branch In Local) After (this branch)
Screenshot 2026-03-25 at 2 14 43 PM Screenshot 2026-03-25 at 2 15 02 PM Test should pass locally as well as in CI ✅

How to test 🧪

Reproduction steps

  • Run alerts-create.spec.ts locally and observe test failures.

Verification steps

  • Run Cypress tests locally and Confirm all alert-related tests (especially alerts-create) pass
  • Run unit tests for AclpPreferenceToggle.test.tsx and confirm all tests pass
  • Verify behavior is consistent in both local and CI runs
Author Checklists

As an Author, to speed up the review process, I considered 🤔

👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support


  • I have read and considered all applicable items listed above.

As an Author, before moving this PR from Draft to Open, I confirmed ✅

  • All tests and CI checks are passing
  • TypeScript compilation succeeded without errors
  • Code passes all linting rules

@pmakode-akamai pmakode-akamai self-assigned this Mar 25, 2026
@pmakode-akamai pmakode-akamai marked this pull request as ready for review March 25, 2026 08:58
@pmakode-akamai pmakode-akamai requested review from a team as code owners March 25, 2026 08:58
@pmakode-akamai pmakode-akamai added Testing ACLP Integration CI (Cloud Interfaces) Support for CC (Core Compute) CloudPulse Integration labels Mar 25, 2026
@jdamore-linode
Copy link
Contributor

Thanks @pmakode-akamai 👍 these were passing in CI because the test runs use the LaunchDarkly {{development}} environment, where the values were set differently than (presumably) the environment you're developing against locally.

(I also kicked off another test run: I flipped the Private Image Sharing feature flag yesterday for testing and forgot to change it back which triggered all these failures. Sorry about that!)

@github-project-automation github-project-automation bot moved this from Review to Approved in Cloud Manager Mar 25, 2026
@linode-gh-bot
Copy link
Collaborator

Cloud Manager UI test results

🔺 2 failing tests on test run #7 ↗︎

❌ Failing✅ Passing↪️ Skipped🕐 Duration
2 Failing886 Passing11 Skipped45m 11s

Details

Failing Tests
SpecTest
access-key.e2e.spec.tsCloud Manager Cypress Tests→object storage access key end-to-end tests » can create an access key with limited access - e2e
object-storage-objects-multicluster.spec.tsCloud Manager Cypress Tests→Object Storage Multicluster objects » can upload, access, and delete objects

Troubleshooting

Use this command to re-run the failing tests:

pnpm cy:run -s "cypress/e2e/core/objectStorage/access-key.e2e.spec.ts,cypress/e2e/core/objectStorageMulticluster/object-storage-objects-multicluster.spec.ts"

@tvijay-akamai tvijay-akamai merged commit 8d2cc6d into linode:develop Mar 25, 2026
34 of 35 checks passed
@github-project-automation github-project-automation bot moved this from Approved to Merged in Cloud Manager Mar 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ACLP Integration CI (Cloud Interfaces) Support for CC (Core Compute) CloudPulse Integration Testing 🚨 Urgent

Projects

Status: Merged

Development

Successfully merging this pull request may close these issues.

4 participants