fix: [UIE-10490, UIE-10564] - Mock relevant flags in alerts-related tests#13532
Merged
tvijay-akamai merged 4 commits intolinode:developfrom Mar 25, 2026
Conversation
Contributor
|
Thanks @pmakode-akamai 👍 these were passing in CI because the test runs use the LaunchDarkly {{development}} environment, where the values were set differently than (presumably) the environment you're developing against locally. (I also kicked off another test run: I flipped the Private Image Sharing feature flag yesterday for testing and forgot to change it back which triggered all these failures. Sorry about that!) |
jdamore-linode
approved these changes
Mar 25, 2026
tvijay-akamai
approved these changes
Mar 25, 2026
Collaborator
Cloud Manager UI test results🔺 2 failing tests on test run #7 ↗︎
Details
TroubleshootingUse this command to re-run the failing tests: pnpm cy:run -s "cypress/e2e/core/objectStorage/access-key.e2e.spec.ts,cypress/e2e/core/objectStorageMulticluster/object-storage-objects-multicluster.spec.ts" |
||||||||||||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description 📝
This PR fixes inconsistencies in Cypress alert-related tests caused by missing feature flag mocks.
Previously, tests were only relying on
aclpServices(linode -> beta/new) flags. While this was somehow passing in CI, it fails locally becauseaclpAlerting/aclp(beta/new) flags were not mocked, leading to inconsistent and buggy behavior.This PR adds the required flag mocks and cleans up test related constants for better clarity.
Related PRs:
alerts-create.spec.tstest failures #13527Changes 🔄
aclpAlertingandaclp(beta/new) (KeptaclpServicesflags as is to support contextual view)alerts-createtests to use the correct constants based on mocked flagsScope 🚢
Target release date 🗓️
March End
Preview 📷
How to test 🧪
Reproduction steps
alerts-create.spec.tslocally and observe test failures.Verification steps
AclpPreferenceToggle.test.tsxand confirm all tests passAuthor Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅