Draft
Conversation
Coverage report
Click to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Magwos
reviewed
Feb 2, 2026
Magwos
left a comment
Magwos
left a comment
There was a problem hiding this comment.
A very few minor comments for the PR + one additional (although probably not necessary) -> Different conventions are used in the comments, either Args or Parameters, should it be homogenized? (I can propose changes to do so if yes!)
litebird_sim/mapmaking/h_n.py
Outdated
|
|
||
| @dataclass | ||
| class h_map_Re_and_Im: | ||
| """A single h_n,m map component for one detector""" |
There was a problem hiding this comment.
Addition of "time split" in the comment?
Suggested change
| """A single h_n,m map component for one detector""" | |
| """A single h_n,m map component for one detector and one time split""" |
litebird_sim/mapmaking/h_n.py
Outdated
| - ``h_maps``: Dictionnary containing the h_n maps for each spin order n,m and each detector. | ||
|
|
||
| - ``coordinate_system``: the coordinate system of the output maps | ||
| (a :class:`.CoordinateSistem` object) |
There was a problem hiding this comment.
Little typo (but I see that it is also in the binner object here:
Suggested change
| (a :class:`.CoordinateSistem` object) | |
| (a :class:`.CoordinateSystem` object) |
| pixel in the map. It is an array of shape `(12 * nside * nside, 3, 3)` | ||
|
|
||
| - ``coordinate_system``: the coordinate system of the output maps | ||
| (a :class:`.CoordinateSistem` object) |
There was a problem hiding this comment.
Correction of the typo
Suggested change
| (a :class:`.CoordinateSystem` object) |
litebird_sim/mapmaking/h_n.py
Outdated
| if not d_mask[idet]: | ||
| continue | ||
|
|
||
| print(np.shape(pix[idet]), " ", np.shape(hwp_angle)) |
There was a problem hiding this comment.
Delete print? (If print to be added to the logs, maybe it would be useful to add as well the detector id)
Suggested change
| print(np.shape(pix[idet]), " ", np.shape(hwp_angle)) |
camilledemay
force-pushed
the
h_n_maps
branch
from
eaa3b75 to
ec508b8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WIP: The goal is to have a module to generates the H_n maps described in https://arxiv.org/abs/2109.05038