Fix missing RTC_OBJC_TYPE macros in webrtc-sys .mm files#930
Open
ackanir wants to merge 2 commits intolivekit:mainfrom
Open
Fix missing RTC_OBJC_TYPE macros in webrtc-sys .mm files#930ackanir wants to merge 2 commits intolivekit:mainfrom
ackanir wants to merge 2 commits intolivekit:mainfrom
Conversation
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
objc_video_factory.mmandobjc_video_frame_buffer.mmreference ObjC classes using bare names (RTCDefaultVideoEncoderFactory,RTCVideoEncoderFactorySimulcast,RTCDefaultVideoDecoderFactory,RTCCVPixelBuffer).When using a custom libwebrtc build with
rtc_objc_prefixset (to avoid ObjC class collisions with other WebRTC copies in the same binary), these classes get renamed but the references in webrtc-sys don't, causing compilation errors against the prefixed headers.For reference:
objc_video_frame_buffer.mmalready usesRTC_OBJC_TYPE(RTCVideoFrameBuffer)on line 38, but the other references in the same file and all references inobjc_video_factory.mmwere missed.