add initial version of cockroachdb extension#131
Conversation
There was a problem hiding this comment.
Looks great @HarshCasper 🚀 - just checked out the extension locally, and installation and make test are working nicely. 👌
Looks good to go from my side, just added a minor comment which would be great to address before merging.
Btw, just wondering - do we also want to add a simple sample app here (similar to what we did for the other recent extensions), or just get the functionality merged for now? (adding a sample could probably be tackled later 👍 )
| """ | ||
| self.start_container() | ||
|
|
||
| if self.tcp_ports: |
There was a problem hiding this comment.
note: The custom logic in here should technically no longer be required, after the changes in #130 . Can you try removing this method, and trigger the CI tests again (which should pull in the latest version of localstack-extensions-utils).
Summary
start-single-node --insecuremode with in-memory store for fast, ephemeral local developmentcockroachdb.localhost.localstack.cloud:4566via TCP protocol detection