Fix GitHub workflows and add customizable URL base#40
Open
iiAhmedYT wants to merge 2 commits intolucko:masterfrom
Open
Fix GitHub workflows and add customizable URL base#40iiAhmedYT wants to merge 2 commits intolucko:masterfrom
iiAhmedYT wants to merge 2 commits intolucko:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A while ago I introduced a very bad fix to make github pages work. It was the VITE_USE_QUERY_ROUTING option.
It was very annoying and honestly not ideal. (Also paste code would disappear from URL)
I came across https://github.com/rafgraph/spa-github-pages which basically solves this issue. I mimicked it's behavior and it works perfectly.
I even introduced a VITE_BASE_URL option so username.github.io/paste/ could work fine!
Also yarn.lock dependencies were outdated so I took liberty in fixing it too,
You could test the url from my repository:
https://iiahmedyt.github.io/paste/