perf: memoize components to prevent unnecessary re-renders#59
Merged
Conversation
- Add memo/PureComponent to MapView, Marker, Polygon, Circle, GroundOverlay, Polyline, TileOverlay, GeoJson (web + native) - Stabilize MapView.web handlers with useCallback and isDraggingRef - Memoize MapContext value to avoid consumer re-renders - Extract inline callbacks in example Home to stable useCallback refs - Wrap example Map with memo(forwardRef)
- Use PureComponent for native MapView - Add memo to web components: MapView, Marker, Polygon, Circle, GroundOverlay, Polyline, TileOverlay, GeoJson - Stabilize MapView.web handlers with useCallback and isDraggingRef - Memoize MapContext value to avoid consumer re-renders - Extract inline callbacks in example Home to stable useCallback refs - Wrap example Map with memo(forwardRef)
…uring drag State updates from setIsDragging caused MapView re-renders mid-drag, resetting the camera position. Using a ref avoids re-renders while still pausing Polyline animation during drag.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Memoize all map components (web + native) to prevent unnecessary re-renders during marker drag and camera events. Previously,
setStatuscalls in the example app triggered full re-render cascades through MapView and all child components, causing visible lag during marker drag operations.memo/PureComponentto MapView, Marker, Polygon, Circle, GroundOverlay, Polyline, TileOverlay, GeoJsonuseCallbackand memoize context valueisDraggingstate with ref to avoid mid-drag re-renders that reset camera positionuseCallbackrefsType of Change
Test Plan
Checklist