fix(ios): marker onPress not firing after navigation back#60
Merged
Conversation
Move press event emission from didSelectAnnotationView: to the existing tap gesture recognizer on annotation views. MKMapView only fires didSelectAnnotationView: when an annotation transitions from deselected to selected — if a marker stays selected after navigating away and back, re-tapping it never fires the delegate. The tap gesture fires on every tap regardless of selection state. Also adds navigation to both example apps (expo-router + react-navigation) with a navigate marker type to reproduce and verify the fix. Closes #58
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
On iOS,
MKMapViewonly firesdidSelectAnnotationView:when an annotation transitions from deselected → selected. If a marker stays selected after navigating away and returning, re-tapping it never fires the delegate — soonPressis silently swallowed.This PR moves press event emission from
didSelectAnnotationView:to the existing tap gesture recognizer on annotation views, which fires on every tap regardless of selection state.Test Plan
onPressfires every timecenterOnPressstill worksChecklist
Closes #58