Unify multi-value interactive prompts with reusable abstraction#109
Merged
lukidoescode merged 2 commits intomainfrom Apr 17, 2026
Merged
Unify multi-value interactive prompts with reusable abstraction#109lukidoescode merged 2 commits intomainfrom
lukidoescode merged 2 commits intomainfrom
Conversation
Extract `prompt_multi_value()` and `MultiValuePromptConfig` to share the two-stage loop pattern (intro message, first prompt with optional default, "Additional pattern" for subsequent entries) between `prompt_ignored_files_loop` and `prompt_influence_patterns`.
…TTY debug output - Move MultiValuePromptConfig to its canonical position (after NonInteractiveProvider impl block, before TerminalInitInteractionProvider) - Add interactive E2E tests for prompt_ignored_files_loop via init command - Add interactive E2E test for prompt_influence_patterns via additional-packages add - Add debug_print_screen to TerminalSession; print screen on wait_for timeout
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extract
prompt_multi_value()andMultiValuePromptConfigto share the two-stage loop pattern (intro message, first prompt with optional default, "Additional pattern" for subsequent entries) betweenprompt_ignored_files_loopandprompt_influence_patterns.