refactor(compile): add trimpath to compile to remove local paths#457
Open
sheldonhull wants to merge 7 commits intomagefile:masterfrom
Open
refactor(compile): add trimpath to compile to remove local paths#457sheldonhull wants to merge 7 commits intomagefile:masterfrom
sheldonhull wants to merge 7 commits intomagefile:masterfrom
Conversation
- Include trimpath to ensure local filepaths from CI or developer don't get included in the produced artifact. - This was added in Go 1.13, so not sure if there is something special to handle adding this flag only if go version > 1.13.
Contributor
|
I feel like the EDIT: Ah, I see, that is from #451 and just wasn't removed when making this PR. I'd suggest cleaning that up :D |
Author
|
My mistake. I did a pr for that but did it on main branch in fork resulting
in my new branch including that. I’ll have to separate this out.
|
Author
|
@jaredallard reverted back so pr changes are now just this. Not sure about compatibility for prior go versions to 1.13 like I mentioned but otherwise this will be good for privacy. Right now compiled binary includes full path. Cheers |
perrito666
reviewed
Feb 23, 2023
Co-authored-by: Horacio Duran <horacio.duran@gmail.com>
jaredallard
approved these changes
Mar 5, 2023
Contributor
jaredallard
left a comment
There was a problem hiding this comment.
Looks reasonable to me :D
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Go documentation on this: