Rogue combat strategy fixes#290
Merged
billy1arm merged 1 commit intomangoszero:masterfrom Mar 25, 2026
Merged
Conversation
001cd3f to
5b51bc3
Compare
5b51bc3 to
24c6534
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lots of rogue improvements here. First off, the bot now looks in the proper place for its combo points. the rogue will now wait for 1-2 points before finishing in normal play, or 3-5 on elites. It will cycle through the set of finishing moves now. The combat-starting behavior for rogues from "attack" command is now centered more around sneaking up first instead of using a bow; use your warrior or hunter for remote pulls. A "sap" command was added for CC.
P.S. The window build fail is from the missing return value that is fixed in another branch.
This change is