Replace session button with Bluetooth fallback drawer when Web Blueto…#911
Replace session button with Bluetooth fallback drawer when Web Blueto…#911marcodejongh wants to merge 1 commit intomainfrom
Conversation
…oth unsupported When the browser doesn't support Web Bluetooth, the party mode button in the queue control bar is replaced with a lightbulb icon button that opens a drawer explaining the limitation and recommending Bluefy for iOS users or Chrome for others. https://claude.ai/code/session_01F3W6NGWS6rfCTF6VbrPvX7
Claude ReviewIssueParty mode functionality lost for non-Bluetooth browsers ( The PR replaces the entire
They just can't illuminate LEDs on the board. The existing Suggested fix: Keep showing |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f45fa9800d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| {/* Party button */} | ||
| <ShareBoardButton /> | ||
| {/* Party button or Bluetooth fallback */} | ||
| {isBluetoothSupported ? <ShareBoardButton /> : <BluetoothFallbackButton />} |
There was a problem hiding this comment.
Preserve party controls when Bluetooth is unsupported
This conditional removes the only entry point to party-mode/session management for browsers without Web Bluetooth (e.g., Safari/Firefox), even though session start/join/end is not Bluetooth-gated in ShareBoardButton (it already exposes Start Session/Join Session tabs and separately handles unsupported BLE in its LED tab). In that environment, users can no longer create, join, or manage sessions from the queue bar, which is a functional regression unrelated to board lighting.
Useful? React with 👍 / 👎.
…oth unsupported
When the browser doesn't support Web Bluetooth, the party mode button in the queue control bar is replaced with a lightbulb icon button that opens a drawer explaining the limitation and recommending Bluefy for iOS users or Chrome for others.
https://claude.ai/code/session_01F3W6NGWS6rfCTF6VbrPvX7